Skip to content

New like button markup with class selectors + also updating other labels on the page. #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2025
Merged

New like button markup with class selectors + also updating other labels on the page. #8888

merged 3 commits into from
Aug 21, 2025

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Aug 11, 2025 •
edited
Loading

  • Display the /my-liked-packages page the same way as other package listing. #8887
  • refactored the rendering of the like button, preparing for making it available on package listing pages
  • update the the template and the like-handling in JS: instead of using the id attribute, relying on CSS class attributes
  • the CSS name was moved to the <component>--<subcomponent> pattern
  • added integration test, since we didn't have it with the button
  • also updating the two "larger" like labels on the packages pages (with extra data attribute for filtering that is needed for the listing page)
  • the rendering or other behavior of the button didn't change (available on staging)

@isoos isoos requested a review from sigurdm August 11, 2025 14:05
@isoos isoos changed the title New like button markup with class selectors. New like button markup with class selectors + also updating other labels on the page. Aug 13, 2025
@isoos isoos merged commit 4f4ad8d into dart-lang:master Aug 21, 2025
32 checks passed
@isoos isoos deleted the like-button branch August 21, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm